Skip to content

Conversation

@yagho-odoo
Copy link

No description provided.

@robodoo
Copy link

robodoo commented Nov 4, 2025

This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged.

Copy link

@malb-odoo malb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing commit description and task id 👀 and title is fucked up i think missing the module ahah

# EXTENDS 'account'
super()._compute_show_delivery_date()
for move in self:
if move.country_code == 'FR':

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See that little field l10n_fr_is_company_french, maybe we could use that ? You can tell me why it would be better ? 👀

A new legislation in france requires the delivery date to be in the header of the invoice
task id: 5231299
@yagho-odoo yagho-odoo force-pushed the 18.0-accountingOnboarding-l10fr-yagho branch from 18961ce to 1dc9bad Compare November 6, 2025 08:31
@yagho-odoo yagho-odoo changed the title [IMP]: added a function in l10n-FR to show delivery dates [IMP] accountant: add a function in l10n-FR to show delivery dates Nov 6, 2025
Copy link

@malb-odoo malb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now to go a bit further, what if the user don't put any value in the delivery date, then we would have nothing. If you look at the other localisation we have some function to add thing when posting the move 👀
Also commit message needs to be adapted for the module name and the task id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants